fmjstudios / helm

🪖 A collection of MIT-licensed Helm Charts
MIT License
13 stars 13 forks source link

fix(charts/linkwarden): sso auth issuer never resolving #33

Open helionmusic opened 5 months ago

helionmusic commented 5 months ago

What this PR does / why we need it

Currently in the Linkwarden chart, when attempting to set an issuer url value for a given provider, the template attempts to validate the the issuer value exists in the list of supported auth providers. Instead it should check for provider against that list.

What ends up happening is since the issuer should be a URL, it will never resolve against that list, and thus the *_ISSUER key never gets set.

Checklist

github-actions[bot] commented 4 months ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

bkoerbel commented 3 months ago

This exact issue has blocked me from using this Linkwarden chart with Authentik. Please merge this fix :)

github-actions[bot] commented 2 months ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.