fmjstudios / helm

🪖 A collection of MIT-licensed Helm Charts
MIT License
13 stars 13 forks source link

fix(charts/linkwarden): adding existingSecret in auth.sso list does not prevent new secret from being created #34

Open helionmusic opened 5 months ago

helionmusic commented 5 months ago

What this PR does / why we need it

Currently in the Linkwarden chart, when setting .Values.linkwarden.auth.sso[*].existingSecret, the chart still attempts to create the auth secret for that given provider. Beyond that there is an error when clientId and clientSecret are not set, leading to your values file requiring at least an empty value for both when using an existing secret.

Special notes for your reviewer

We could probably bundle this in with #33 - I've left the Chart version untouched for that reason. If you'd rather this be a separate version bump I can add the change

Checklist

github-actions[bot] commented 4 months ago

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.