search

fmperf-project / fmperf

Cloud Native Benchmarking of Foundation Models
Apache License 2.0
21 stars 10 forks source link

Unit tests for verifying imports #24

Closed GhaziSyed closed 4 months ago

GhaziSyed commented 5 months ago

added a script that runs unit tests to see -if library imports of fmperf are working -if kuberenets import is working -if k8 python client is working -also added a github action workflow to automate the testing upon push and pull request

tdoublep commented 4 months ago

@GhaziSyed The diff still looks bigger than it should. Could you please try to merge/rebase against latest changes on main. It should be enough to hit the "Update branch" button on github.

GhaziSyed commented 4 months ago

@GhaziSyed The diff still looks bigger than it should. Could you please try to merge/rebase against latest changes on main. It should be enough to hit the "Update branch" button on github.

GhaziSyed commented 4 months ago

@tdoublep this seems to be working now I believe. The branch is updated with the main and the pull request is modified accordingly.

tdoublep commented 4 months ago

Is there a reason you closed the PR?

GhaziSyed commented 4 months ago

Clicking the update button did update the branch but then closed the PR automatically for some reason.

I also noticed the file tests\test_imports.py file wrongly committed which I also want to remove. I will work on creating a new PR, as git checkout ghs-tests -- tests/test_imports.py does not remove the file from git.

tdoublep commented 4 months ago

I don't think there is any need to create a new PR - you should just be able to re-open this one?

I also noticed the file tests\test_imports.py file wrongly committed which I also want to remove. I will work on creating a new PR, as git checkout ghs-tests -- tests/test_imports.py does not remove the file from git.

That is not the correct command to remove a file from git, you are looking for:

git rm tests/test_imports.py
GhaziSyed commented 4 months ago

Thanks. The branch seems ready now