search

fnl / segtok

Segtok v2 is here: https://github.com/fnl/syntok -- A rule-based sentence segmenter (splitter) and a word tokenizer using orthographic features.
http://fnl.es/segtok-a-segmentation-and-tokenization-library.html
MIT License
170 stars 22 forks source link

Remove license file from data_files #25

Closed PrimozGodec closed 2 years ago

PrimozGodec commented 2 years ago

Having the license file in data_files causees the license file to get placed in the root folder of the environment (beside lib, bin, etc folder) which is not the place where it should be. It also disables us to codesign the Python application that we distribute as a macOS app.

In this PR I remove the license file from data_files since it is not required to have there. The license file gets placed in the package (tar.gz) anyway. I would be more than happy if you can merge this and make a new release of a package.

fnl commented 2 years ago

After some research, it seems there finally is a correct way to add license file references via setup tools, by using the license_file[s] configuration parameter: https://setuptools.pypa.io/en/latest/userguide/declarative_config.html Therefore, instead of dropping the license completely, I would suggest to rename that parameter accordingly. Would that still resolve your issue?

PrimozGodec commented 2 years ago

Thank you for your answer. Yes using license_files would be ok too. I changed the PR.

fnl commented 2 years ago

Replaced setup.py data_files with the proper license_files configuration. Thank you, Primoz!

fnl commented 2 years ago

Released as 1.5.11

PrimozGodec commented 2 years ago

@fnl thank you for your fast response. :)