focustense / easymod

Modding for the modern age.
44 stars 2 forks source link

Merged output from wig-based mods is has wrong head part data with dewiggifier off #164

Closed focustense closed 2 years ago

focustense commented 2 years ago

Surfaced recently on Discord, when a user was trying to merge High Poly NPC Overhaul (2.0, where all the hairs are wigs). The wig conversion option was turned off, and the facegen files had no hair (as expected), but the merged plugin was missing the HighPoly_HairBald part and instead had hair.

Cause is that the DewiggifyFacegensTask honors the wig conversion setting, but the DewiggifyRecordsTask does not honor the setting and always runs regardless. Thus, counterintuitively, not enabling wig conversion is not only riskier, but guaranteed to cause issues with these mods.

Solution is simple, just fix the task to follow the setting. Also, this setting should really be disabled by default since it was always an experimental feature, unsure why it's on by default.