Add vm_update class for improved vm reconfiguration

fog / fog-vsphere

Fog for vSphere

MIT License

36 stars 63 forks source link

Add vm_update class for improved vm reconfiguration #142

Closed leewaa closed 6 years ago

leewaa commented 6 years ago

As part of https://github.com/theforeman/foreman/pull/5569

This adds the functionality to edit the network of an existing network and fixes some other issues with updating a vm.

It also brings updating a vm into one request to the vsphere sdk reducing it from individual requests for each attribute.

TODO

[x] Add tests
[x] add mock implementation

leewaa commented 6 years ago

Thanks @timogoebel for the push in the right direction.

leewaa commented 6 years ago

Note: The tests here are basically useless.. @timogoebel and myself will be coming up with a better test strategy for the requests in the future so that we can bring up the stability and maintainability of this.

timogoebel commented 6 years ago

Thanks, @leewaa.

timogoebel commented 6 years ago

I just released v2.2.0 with these changes.