Fixes #188 - Update ruby string method to prevent traceback

fog / fog-vsphere

Fog for vSphere

MIT License

36 stars 63 forks source link

Fixes #188 - Update ruby string method to prevent traceback #189

Closed chris1984 closed 5 years ago

chris1984 commented 5 years ago

@timogoebel can I get a review please? I tried to make a vm yesterday with with your gist and hit this, looking at the ruby docs .blank is not a method for a string anymore. After switching to .empty I was able to build with the script.

chris1984 commented 5 years ago

@timogoebel I fixed the first part of the tests complaining about the bundler version being unsupported. Now I am hitting something else with the tests, I can fix that in a separate pr. I have addressed Ewoud's comment

timogoebel commented 5 years ago

Thanks, @chris1984 and @ekohl.