Fix issues with dependencies breaking Travis CI - Githubissues

fog / fog-xenserver

Module for the 'fog' gem to support XENSERVER

MIT License

16 stars 22 forks source link

Fix issues with dependencies breaking Travis CI #64

Closed HashNotAdam closed 7 years ago

HashNotAdam commented 7 years ago

Tests that check the number of attributes on a class in 1.8.7/ree still fail however I can't even compile Ruby that old to be able to look into it.

coveralls commented 7 years ago

Changes Unknown when pulling f92297af45c991ff73702c7bf4a39ce535aa1111 on HashNotAdam:fix/github_code_checks into on fog:master.

coveralls commented 7 years ago

Changes Unknown when pulling f92297af45c991ff73702c7bf4a39ce535aa1111 on HashNotAdam:fix/github_code_checks into on fog:master.

coveralls commented 7 years ago

Changes Unknown when pulling f92297af45c991ff73702c7bf4a39ce535aa1111 on HashNotAdam:fix/github_code_checks into on fog:master.

plribeiro3000 commented 7 years ago

Btw, i can check the errors with 1.8.7 and if i'm not mistaken we should drop support for it already.

I will check on that and get back here soon.

plribeiro3000 commented 7 years ago

Yeap. We can drop support for 1.8.7. =)

plribeiro3000 commented 7 years ago

Ok then. Do you want to fix your git credentials before i merge this?

HashNotAdam commented 7 years ago

Sorry @plribeiro3000, I don't understand

plribeiro3000 commented 7 years ago

Your commit does not contain your personal mail so github wont recognize you as the author of those changes. Take a look here: https://help.github.com/articles/setting-your-email-in-git/

HashNotAdam commented 7 years ago

@plribeiro3000 Oh wow! I can't believe you're the first person to pick that up — rookie mistake. Thanks

plribeiro3000 commented 7 years ago

No worries. =)

I'm glad to help. 😉

coveralls commented 7 years ago

Changes Unknown when pulling e7a76f701b22f1cb644c9368abf0c7643239a81b on HashNotAdam:fix/github_code_checks into on fog:master.

plribeiro3000 commented 7 years ago

Awesome!

plribeiro3000 commented 7 years ago

Thank you very much for your contribution. =)