Closed HashNotAdam closed 7 years ago
Btw, i can check the errors with 1.8.7
and if i'm not mistaken we should drop support for it already.
I will check on that and get back here soon.
Yeap. We can drop support for 1.8.7
. =)
Ok then. Do you want to fix your git credentials before i merge this?
Sorry @plribeiro3000, I don't understand
Your commit does not contain your personal mail so github wont recognize you as the author of those changes. Take a look here: https://help.github.com/articles/setting-your-email-in-git/
@plribeiro3000 Oh wow! I can't believe you're the first person to pick that up — rookie mistake. Thanks
No worries. =)
I'm glad to help. 😉
Awesome!
Thank you very much for your contribution. =)
Tests that check the number of attributes on a class in 1.8.7/ree still fail however I can't even compile Ruby that old to be able to look into it.