search

fog / fog-xenserver

Module for the 'fog' gem to support XENSERVER
MIT License
16 stars 22 forks source link

avoid monkey-patching Hash #71

Closed onyxblade closed 6 years ago

onyxblade commented 6 years ago

closes https://github.com/fog/fog-xenserver/issues/70

onyxblade commented 6 years ago

emmmmm... Some tests break due to xenserver has no compute service but I guess those are not related to this pr?

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.2%) to 94.252% when pulling c0e083a883ec21c195b8c2f67524708cea4886dc on CicholGricenchos:avoid-monkey-patching-hash into 50ef0139a40e4af160a97add9eb5ca40b6436078 on fog:master.

plribeiro3000 commented 6 years ago

Thanks for your PR @CicholGricenchos .

While you are here i wonder where we should drop it and do it inline or leave the keys as strings all together.

Will merge this and leave this conversation and idea to another PR.

Thanks!