search

fomightez / cairo-jupyter

Jupyter notebooks hosted via mybinder.org where cairo works
https://mybinder.org/v2/gh/fomightez/cairo-jupyter/master?filepath=index.ipynb
3 stars 1 forks source link

Setup hotfix #8

Closed stuaxo closed 6 years ago

stuaxo commented 6 years ago

Bah, the original extension re-org breaks the build.

Remembered, why I hadn't made a PR for this branch originally.. my initial setup.py organisation was a bit weird/hacky.

This is more standard and shouldn't break the build.

It should be possible to have circleci run as a check against PRs, then we can get the full benefit of CI.. probably worth doing before merging this, just in case.

fomightez commented 6 years ago

I turned on the the building of forked pull requests in CircleCI just now. Unfortunately, I don't think it works after the fact because nothing happened following that. Or the 'conflict' is blocking it?

stuaxo commented 6 years ago

Yep, the conflict was the issue.

Then it got stuck because we had the absolute git url to this repo to install the extension (binder/requirements.txt) so i just changed it to this project -e . and it's happy again.

I reckon this is definitely a plus already :)

fomightez commented 6 years ago

Definitely the addition of CircleCI has been a plus already.