fongecore / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Crash when album name nil #105

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Load a CD (serial 90C410 for example) with no Artist or Album info in
freedb, they return "rt 2)" for an Artist typically when that happens and
nil ("") for album name.
2. Choose to rip all tracks
3. Boom

What is the expected output? What do you see instead?

I would expect a program-generated error message rather than a crash and
trace.  See dump below.

What version of rubyripper are you using? On what operating system? Are you
using the gtk2 or the commandline interface?

rr 0.3 Gentoo Linux, cli

Please provide any additional information below.

------------

Should all tracks be ripped ? (y/n) y
Tracks to rip are 1, 2, 3, 4, 5, 6, 7, 8
/usr/lib64/ruby/site_ruby/rr_lib.rb:682:in `gsub!': can't convert nil into
String (TypeError)
        from /usr/lib64/ruby/site_ruby/rr_lib.rb:682:in `prepare_dirs'
        from /usr/lib64/ruby/site_ruby/rr_lib.rb:681:in `each'
        from /usr/lib64/ruby/site_ruby/rr_lib.rb:681:in `prepare_dirs'
        from /usr/lib64/ruby/site_ruby/rr_lib.rb:634:in `initialize'
        from /usr/bin/rrip-cli:264:in `new'
        from /usr/bin/rrip-cli:264:in `main'
        from /usr/bin/rrip-cli:31:in `initialize'
        from /usr/bin/rrip-cli:317:in `new'
        from /usr/bin/rrip-cli:317

-=-------------- line 682 on my copy -----------------
                        @settings['destination_dir'].gsub!(key, value) #
change the keys for the values that stay the same for the whole cd

Original issue reported on code.google.com by geniuswe...@gmail.com on 31 Jul 2007 at 3:59

GoogleCodeExporter commented 8 years ago
I believe this is fixed in the 0.4 version. Please only file issues with the 
latest 
released version of rubyripper or the svn version (after checking the svn logs).

Original comment by rubyripp...@gmail.com on 6 Aug 2007 at 6:03