Crash when trying to rip

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1. CD reports Multiple hits from freedb
2. Select one of them
3. hit rip now and crash

What is the expected output? What do you see instead?
[jebediah@manger]-(~/src/rubyripper/svn)$ ./rubyripper_gtk2.rb
Using cd-discid, freedb string = 7e07e50a 10 150 7350 19820 35030 45330
50060 68440 101355 105632 142867 2023
./rr_lib.rb:50:in `gsub!': can't convert nil into String (TypeError)
        from ./rr_lib.rb:50:in `get_filename'
        from ./rr_lib.rb:50:in `each'
        from ./rr_lib.rb:50:in `get_filename'
        from ./rr_lib.rb:827:in `prepare_dirs'
        from ./rr_lib.rb:825:in `each'
        from ./rr_lib.rb:825:in `prepare_dirs'
        from ./rr_lib.rb:761:in `settings_ok'
        from ./rubyripper_gtk2.rb:138:in `rip_cd'
        from ./rubyripper_gtk2.rb:136:in `initialize'
        from ./rubyripper_gtk2.rb:136:in `new'
        from ./rubyripper_gtk2.rb:136:in `rip_cd'
        from ./rubyripper_gtk2.rb:12:in `to_proc'
        from ./rubyripper_gtk2.rb:952:in `call'
        from ./rubyripper_gtk2.rb:952:in `main'
        from ./rubyripper_gtk2.rb:952

What version of rubyripper are you using? On what operating system? What is
your version of the ruby-gtk bindings?
svn 81, Debian

Please provide any additional information below.

Original issue reported on code.google.com by mordbr...@gmail.com on 10 Mar 2007 at 11:49

GoogleCodeExporter commented 8 years ago

Revision 76 is the last one without this bug.

Original comment by mordbr...@gmail.com on 10 Mar 2007 at 11:51

GoogleCodeExporter commented 8 years ago

Revision 76 is the last one without this bug.

Original comment by mordbr...@gmail.com on 11 Mar 2007 at 12:14

GoogleCodeExporter commented 8 years ago

Ok, it seems this happen if a particular value isn't found for a variable in 
the 
freedb response. Am I right that this doesn't happen on all cd's?

Original comment by rubyripp...@gmail.com on 11 Mar 2007 at 12:20

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

The only two I tried it with did it.  Haven't tested beyond that.

Original comment by mordbr...@gmail.com on 11 Mar 2007 at 1:27

GoogleCodeExporter commented 8 years ago

Are you by any chance using %va in the naming scheme for a normal cd?

Original comment by rubyripp...@gmail.com on 11 Mar 2007 at 10:18

GoogleCodeExporter commented 8 years ago

The problem is solved in latest commit.

Original comment by rubyripp...@gmail.com on 12 Mar 2007 at 8:27

Changed state: Fixed

fongecore / rubyripper

Crash when trying to rip #62