fongecore / rubyripper

Automatically exported from code.google.com/p/rubyripper
0 stars 0 forks source link

Rubyripper crasches when rip is started #67

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
What is the expected output? What do you see instead?

Maybe a copy of #62..? After inserting a cd and telling rr to rip, this 
happen:

Should all tracks be ripped ? (y/n) y
Tracks to rip are 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
./rr_lib.rb:55:in `gsub!': can't convert nil into String (TypeError)
        from ./rr_lib.rb:55:in `get_filename'
        from ./rr_lib.rb:55:in `get_filename'
        from ./rr_lib.rb:845:in `prepare_dirs'
        from ./rr_lib.rb:843:in `prepare_dirs'
        from ./rr_lib.rb:779:in `settings_ok'
        from ./rubyripper_cli.rb:169:in `main'
        from ./rubyripper_cli.rb:31:in `initialize'
        from ./rubyripper_cli.rb:273

What version of rubyripper are you using? 

svn 84

On what operating system? 

Kubuntu Linux 

Are you using the gtk2 or the commandline interface?

The problem appear in both versions

Please provide any additional information below.

Original issue reported on code.google.com by crazysw...@gmail.com on 11 Mar 2007 at 8:51

GoogleCodeExporter commented 8 years ago
I do think it's a copy indeed, but nevertheless this confirms that the problem 
hasn't been solved. I'll try to digg a little deeper.

Original comment by rubyripp...@gmail.com on 11 Mar 2007 at 10:34

GoogleCodeExporter commented 8 years ago
Can you post your settings file? I can't reproduce it right now.

Original comment by rubyripp...@gmail.com on 12 Mar 2007 at 6:06

GoogleCodeExporter commented 8 years ago
Sure, here it is. I also did some debugging, adding some puts:

-------------------------------
    {'%a' => settings['cd'].artist, '%b' => settings['cd'].album, '%f' => codec, 
'%g' => settings['cd'].genre, '%y' => settings['cd'].year, '%n' => 
sprintf("%02d", 
track), '%va' => settings['cd'].various_artists[track - 1], '%t' => 
settings['cd'].tracklist[track - 1]}.each{|key,value| 
puts(key)
puts(value)     
filename.gsub!(key, value)
}
------------------------------

resulting in 

------------------------------
Should all tracks be ripped ? (y/n) y
Tracks to rip are 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11
%f
wav
%g
nil
./rr_lib.rb:58:in `gsub!': can't convert nil into String (TypeError)
        from ./rr_lib.rb:58:in `get_filename'
        from ./rr_lib.rb:55:in `get_filename'
        from ./rr_lib.rb:846:in `prepare_dirs'
        from ./rr_lib.rb:844:in `prepare_dirs'
        from ./rr_lib.rb:780:in `settings_ok'
        from ./rubyripper_cli.rb:169:in `main'
        from ./rubyripper_cli.rb:31:in `initialize'
        from ./rubyripper_cli.rb:273
/home/effo/rrip/rubyripper>
----------------------------------------

Looks like it bails out when genre is blank

Original comment by crazysw...@gmail.com on 12 Mar 2007 at 7:15

Attachments:

GoogleCodeExporter commented 8 years ago
This is with latest truk (87)

Original comment by crazysw...@gmail.com on 12 Mar 2007 at 7:20

GoogleCodeExporter commented 8 years ago
Can you check out the very latest svn (89)? I almost believe that I've fixed it.

Original comment by rubyripp...@gmail.com on 12 Mar 2007 at 7:56

GoogleCodeExporter commented 8 years ago
It works fine now! Way to go, man!

Original comment by crazysw...@gmail.com on 12 Mar 2007 at 8:22

GoogleCodeExporter commented 8 years ago
Superb! Now I can at least get some good sleep tonight :D

Nothing is more frustrating than a bug, where you don't have any idea what 
might be 
wrong.

Original comment by rubyripp...@gmail.com on 12 Mar 2007 at 8:26