fonttools / fontbakery

🧁 A font quality assurance tool for everyone
https://fontbakery.readthedocs.io
Apache License 2.0
558 stars 103 forks source link

Check language support #2213

Open davelab6 opened 6 years ago

davelab6 commented 6 years ago

We should better check OS/2 table ulCodePageRange* values (there's a few) based on pyfontaine/similar analysis of the actual char set.

Because our language support analysis got simplified from pyfontaine I think this is actually a fair bit of work.... A simple way would be to check the metadata.pb scripts keys against these os/2 values.

HinTak commented 6 years ago

Fontval already does that.

davelab6 commented 6 years ago

https://github.com/googlei18n/noto-fonts/issues/902 is a case where this is set wrong and making the fonts unusable for users.

@HinTak indeed, would be great to port the check logic of fontval to fontbakery as this check is off the highest priority because it's an OpenType specification issue (must be correct for any and all distributors) and stops fonts from working.

felipesanches commented 5 years ago

The critical portion of this issue was split out to issue #2474