Please check if the PR fulfills these requirements
[x] The branch naming convention follows our guidelines
[x] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR allows users to either enable or disable metrics export for the services included in the Servarr deployment, using a proper flag.
The Prometheus stack is not deployed directly with the Helm chart (it is not a dependency anymore).
What is the current behavior? (You can also link to an open issue here)
Prometheus stack is deployed and metrics are exported.
What is the new behavior (if this is a feature change)?
Prometheus stack is not deployed and metrics can be exported, if configured to do so.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Fingerprint of the deployment is highly reduced:
Pormetheus stack (with grafana) is not deployed anymore
Sidecar pods for metric export are not automatically created
If users want to export metrics, they myust have a pre-deployed, working Prom stack (and its CRDs installed in the target cluster).
Other information:
This PR will allow us to keep working on the pipeline/CICD features 'cause it will remove the need for a working K8S cluster (even lightweight as Kind) to even test the chart.
Please check if the PR fulfills these requirements
[x] The branch naming convention follows our guidelines
[x] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR allows users to either enable or disable metrics export for the services included in the Servarr deployment, using a proper flag. The Prometheus stack is not deployed directly with the Helm chart (it is not a dependency anymore).
Prometheus stack is deployed and metrics are exported.
Prometheus stack is not deployed and metrics can be exported, if configured to do so.
Fingerprint of the deployment is highly reduced:
Pormetheus stack (with grafana) is not deployed anymore
Sidecar pods for metric export are not automatically created If users want to export metrics, they myust have a pre-deployed, working Prom stack (and its CRDs installed in the target cluster).
Other information:
This PR will allow us to keep working on the pipeline/CICD features 'cause it will remove the need for a working K8S cluster (even lightweight as Kind) to even test the chart.