search

for-GET / jesse

jesse (JSon Schema Erlang) is an implementation of a JSON Schema validator for Erlang.
https://github.com/for-get/jesse
Apache License 2.0
124 stars 64 forks source link

default schema version is parent schema version #94

Closed dziaineka closed 2 years ago

dziaineka commented 4 years ago

Hello!

I provide to 

    Result = jesse:validate("./" ++ binary_to_list(SchemaName), Data,
        [
            {default_schema_ver, <<"http://json-schema.org/draft-04/schema#">>}
        ]),

schema with $ref inside, and set draft-04 in options.

When jesse resolves refs it uses lib-wide default schema version draft-03. I think it's better to use parent schema version.

Thank you!

andreineculau commented 3 years ago

I can't seem to be able to approve running the workflow. 500 from GitHub...

I haven't had the time to think of the consequences of this change. Apologies.

image

dziaineka commented 2 years ago

Already fixed in 6cfd1c09ff7abfcbce445e44583cd3a41a5935af