forc-db / Global_Productivity

Creative Commons Attribution 4.0 International
2 stars 0 forks source link

SI cleanup #60

Closed teixeirak closed 4 years ago

teixeirak commented 4 years ago

@beckybanbury, I'm making a new issue, separate from #44, to track minor cleanup of SI materials.

General

Table S1

Fig. S1.

Fig. S2

Fig. S3

Figs. S4-S7

Figs. S8-S9

beckybanbury commented 4 years ago

@teixeirak I've been confused by the definition of temperature and precipitation seasonality: the definitions given by worldclim are here: http://worldclim.org/bioclim Can you make any sense of them?

beckybanbury commented 4 years ago

@teixeirak all the variables that are in the table we did test (they're mentioned as being non-significant at the end of the results section); shall I take them out anyway if we don't use them in the discussion/graphs?

teixeirak commented 4 years ago

@teixeirak all the variables that are in the table we did test (they're mentioned as being non-significant at the end of the results section); shall I take them out anyway if we don't use them in the discussion/graphs?

no, leave them in.

beckybanbury commented 4 years ago

@teixeirak Re: the labels above each row, I plotted them that way because it's hard to fit in the longer flux names (e.g. ANPP woody stem) and ratio names along the y axis without having names overlap. I'm having that issue trying to replot the ratios, just because the plots are small and the labels are long - if I shrink the labels to fit them in, it becomes quite hard to read.

teixeirak commented 4 years ago

@teixeirak Re: the labels above each row, I plotted them that way because it's hard to fit in the longer flux names (e.g. ANPP woody stem) and ratio names along the y axis without having names overlap. I'm having that issue trying to replot the ratios, just because the plots are small and the labels are long - if I shrink the labels to fit them in, it becomes quite hard to read.

Oh, I see. Why don't you just drop the letters, then? Those are off, and are never cited. Then, change the y label to "C flux (Mg ha-1 yr-1)".

beckybanbury commented 4 years ago

ratio_grid_plots

sure! How is this for the ratio plots?

teixeirak commented 4 years ago

@teixeirak I've been confused by the definition of temperature and precipitation seasonality: the definitions given by worldclim are here: http://worldclim.org/bioclim Can you make any sense of them?

No... I also looked at those descriptions and agree that they're inadequate. I guess it takes a bit more digging (maybe a google scholar search for "worldclim" and "temperature seasonality"?). I'll have to look back-- I may have figured it out at one point in the past.

teixeirak commented 4 years ago

Gr

sure! How is this for the ratio plots?

Great! Just remember a y-axis label ("Flux ratio" or just "ratio")

beckybanbury commented 4 years ago

@teixeirak I've just pushed an updated copy of SI. I've a problem with the blank pages that are getting added in (if you know how to remove them that would be handy as I can't seem to!), but otherwise let me know if any other alterations are needed!

teixeirak commented 4 years ago

I spent a bit of time trying to get rid of those extra pages, but no success.

I also tried to increase the font size on Table S1, which has small font but lots of extra space.

teixeirak commented 4 years ago

I noticed a couple other small problems, now added to the list above.

beckybanbury commented 4 years ago

@teixeirak I've edited some of the figures, but for some reason the appendix is knitting to html instead of pdf. Would you mind trying to knit and see if you have the same problem so I know whether its an issue with the code or with my laptop?

teixeirak commented 4 years ago

I'm getting the same problem. (No wonder my attempted changes yesterday didn't seem to have any affect on the .pdf!)

beckybanbury commented 4 years ago

fyi I've fixed this

beckybanbury commented 4 years ago

@teixeirak would you be able to review the updated appendix, and see if you think we need anything else? I think we pretty much have anything, but it would be good to get your opinion!

teixeirak commented 4 years ago

Sorry for the slow response on this! I’ll get to it ASAP.

teixeirak commented 4 years ago

Looks great from a first pass! Let's call it good for now but stay open to the possibility of adding if we find something missing.

teixeirak commented 4 years ago

The one remaining point here is now covered in issue #68.