search

forcedotcom / EMP-Connector

A simplified cometd connector for Enterprise Messaging Platform
BSD 3-Clause "New" or "Revised" License
185 stars 243 forks source link

Report disconnection #13

Closed mrkam2 closed 6 years ago

mrkam2 commented 7 years ago

As it was mention in another issue https://github.com/forcedotcom/EMP-Connector/issues/4, the subscription becomes dead after a period of time without the client being notified. Is it possible to report disconnection so that the client can reconnect?

sfdc-hhildebrand commented 7 years ago

Yes. I am reworking this on the other branch, which will hopefully include some new things like this. Currently, it's reconnecting always, but I will rework that into a better handler pattern with auth failures and others

mrkam2 commented 7 years ago

Cool, do you have a timeline for it?

mrkam2 commented 7 years ago

I looked into that branch and it looked abandoned to me :-) Especially because there was something fixed on the server side.

sfdc-hhildebrand commented 7 years ago

Yes, that fix solved the immediate problem that instigated the branch. I've branched that yet again for internal work I'm doing. But I have some good ideas I would like to integrate back in and the handling of the connection failure is basically the work needed to do what this issue is asking. Simply replace the retry with a callback registered with the connector.

I can't promise when I can get to this as we're approaching release freeze and I'm stretched pretty thin on the backend server side of things.

itssandesh commented 7 years ago

Hey, we are also running into the same issue. Did you get any chance to look into it further? Any pointers are also highly appreciated. Thanks

deepakkapoor23 commented 6 years ago

Is there a fix/workaround/extension available for this in the master branch? It doesn't seem to be reconnecting automatically as claimed by the author.

johnsonlu commented 6 years ago

Is there any update on this issue?

pbn-sfdc commented 6 years ago

This is fixed, after re-handshake the EmpConnector will automatically subscribe to topics.

pbn-sfdc commented 6 years ago

Closing this.