forcedotcom / SalesforceMobileSDK-Android

Android SDK for Salesforce

Other

341 stars 386 forks source link

Push notification encryption (follow-up) #2535

Closed wmathurin closed 5 months ago

wmathurin commented 6 months ago

cipher modes are in an enum
methods to encrypt/decrypt with RSA expect a cipher mode
there is a new method (Encryptor.decryptWithRSAMultiCipherNodes) called by PushNotificationDecryptor which tries the new RSA cipher mode and then the legacy one
SalesforceKeyGenerator is using the same cipher mode as before (otherwise the encryption key is not readable after upgrade)
during push device registration with Salesforce, we add the CipherName parameter if the app is configured to talk to API 60 (or greater)

mobilesdk-bot commented 6 months ago

	2 Warnings
:warning:	libs/SalesforceSDK/src/com/salesforce/androidsdk/app/SalesforceSDKUpgradeManager.java#L149 - Consider using `apply()` instead; `commit` writes its data to persistent storage immediately, whereas `apply` will handle it in the background
:warning:	libs/SalesforceSDK/src/com/salesforce/androidsdk/config/LoginServerManager.java#L298 - Use of this function is discouraged because resource reflection makes it harder to perform build optimizations and compile-time verification of code. It is much more efficient to retrieve resources by identifier (e.g. `R.foo.bar`) than by name (e.g. `getIdentifier("bar", "foo", null)`).

Tests results for SalesforceSDK

Generated by :no_entry_sign: Danger