forem / admin-docs

Empowering Forem Creators
24 stars 25 forks source link

Contact email address #27

Closed Ridhwana closed 2 years ago

Ridhwana commented 2 years ago

I'm logging this issue but just waiting for @JennieOcken's confirmation that the feature behaves as product expects it to. I'll add a comment here when its ready to be worked on and co-ordinate the deploy.

Explain the changes

Introduction of a contact email link.

Currently across the site, we use the default_email as the email. This email displays the email address from which emails are being sent from for Forem Cloud instances that are configured with Sendgrid. This is usually noreply@forem.com.

However, this default_email is also being used for contact links across the site. As an example it will say: "Contact noreply@forem.com for custom bulk pricing and partnerships."

Hence, I've added a specific contact field. The contact field gives the Forem an opportunity to provide an email that are used for any contact links. It is the email where users can get in touch with the Forem or their team."

In doing so, I took the opportunity to clean up the user interface and experience a little bit.

BEFORE:

Screenshot 2022-02-09 at 14 50 41

AFTER:

Screenshot 2022-02-09 at 14 53 05

I want to make a note that the default value for the contact field will however be the "default email" that is used for Sendgrid emails. This is so that views render properly with a value on first load.

Suggested changes

From what I can see, it would be updates to:

  1. https://admin.forem.com/docs/advanced-customization/config/emails (add contact email address and remove default)
  2. https://admin.forem.com/docs/advanced-customization/config/email-digest-frequency (move the periodic digest frequency to (1) above.

Additional context

A demo: https://www.loom.com/share/e1615e5442d5422382edb5db603ead43

Please feel free to ping me for any screenshots etc.

cc @ellativity

Ridhwana commented 2 years ago

@ellativity this has been approved by product and is ready to be worked on. Thank you in advance!

Ridhwana commented 2 years ago

This was implemented and merged already as well.