search

foresterre / cargo-msrv

🦀 Find the minimum supported Rust version (MSRV) for your project
https://foresterre.github.io/cargo-msrv
Apache License 2.0
913 stars 31 forks source link

Document package option for workspaces #1061

Open mert-kurttutan opened 1 week ago

mert-kurttutan commented 1 week ago

Hi, Thanks alot for your nice project !!

One type of api I could not find is cargo build -p ... where you run cargo command on a specific package.

So, when I want to check msrv of a crate inside a workspace, I usually do: cargo msrv -- cargo check -p $crate_name. That is sufficient for my purposes.

I wonder if it could be better to have an API like cargo msrv -p $crate_name

Another suggestion is to add a piece of documentation regarding this type of example where you have to manage workspace.

foresterre commented 1 week ago

Thanks for your feedback! I think this is similar to #1023, do you agree?

There have been some steps made for improved workspace support already but more, and that should include workspace package selection, is on the way.

mert-kurttutan commented 1 week ago

Yes. I wanted to make it clear the point about package api of cargo build and also about the documentation