search

forge / plugin-arquillian

Forge Arquillian Plugin
http://www.jboss.org/arquillian
19 stars 16 forks source link

Patch for creating TestNG based Test Classes #24

Closed sathiyaseelan closed 11 years ago

sathiyaseelan commented 11 years ago

Hi paul, I've updated the patch as we discussed.

lincolnthree commented 11 years ago

Hey there, thanks for your contributions!

The reason for the wait is because the primary maintainer of this plugin is inactive on the project, so I'll try to get @aslakknutsen to take a look instead. Sorry for your inconvenience!

sathiyaseelan commented 11 years ago

It's okay :)

lincolnthree commented 11 years ago

Hey, has anyone been in touch with you yet?

sathiyaseelan commented 11 years ago

No..Not yet

paulbakker commented 11 years ago

Hi Sathiya,

On April 8 I sent you an email:

"Sorry, I was still waiting for the pull request to be fixed. It still contains some old commits, so I can't merge it cleanly: https://github.com/forge/plugin-arquillian/pull/24/commits Can you fix that? The changes look good, so I'm happy to merge it :)"

Did you try to clean it up? It still has a merge conflict, so I can't merge it.... I went over the code again just now and noticed that the default test framework is now test-ng. I think de default should still be junit, because that was the original behaviour.

lincolnthree commented 11 years ago

Yes. The default should stay JUnit, but Test-ng should be an option.

sathiyaseelan commented 11 years ago

Hi.. I tried so much to remove the older commits.But I couldn't (Sorry, I'm a newbie ) So I've created another pull request with the changes. And I've changed back the default test framework as "Junit"

https://github.com/forge/plugin-arquillian/pull/28