forge / plugin-arquillian

Forge Arquillian Plugin
http://www.jboss.org/arquillian
19 stars 16 forks source link

JUnit should be the default test framework #35

Open agoncal opened 10 years ago

agoncal commented 10 years ago

The command arquillian-setup should be optional, but if we use it, JUnit should be the default. At the moment, arquillian-setup asks you which test framework (TestNG or Junit). By default, it shouldn't ask, and use JUnit

[ArqEntity.java]$ arquillian-setup

[0] - testng
[1] - junit

***ERROR*** Test Framework must be specified.
***ERROR*** Test Framework Version must be specified.
bartoszmajsak commented 10 years ago

Why JUnit in particular?

agoncal commented 10 years ago

Because it's the one most commonly used : http://www.google.com/trends/explore#q=junit%2C%20testng&cmpt=q

bartoszmajsak commented 10 years ago

Well that's questionable ;) But I agree there should be the default for convenience. EDIT: Ok, new keywords are ambiguous :)

agoncal commented 10 years ago

Well, one or the other, really. A default would be great as more and more Forge commands have defaults (less typing) and it would be good if Arquillian also had more defaults

bartoszmajsak commented 10 years ago

Sure, I was trying to be a smartass today ;) I assume we are still talking about 1.x? If that's for 2.x I guess we will need to first bring the changes to this repository.

I will have a look at it this weekend.

Cheers!

aslakknutsen commented 10 years ago

@bartoszmajsak yea, very questionable.. I always prefer cucumber salad over junit coding.. ;)

agoncal commented 10 years ago

All these issues are about 2.x

aslakknutsen commented 10 years ago

@bartoszmajsak comments are based on this branch; https://github.com/aslakknutsen/plugin-arquillian/tree/forge2

I will push it to upstream master. Just gotta get the test suite fully functional again

bartoszmajsak commented 10 years ago

@aslakknutsen can you create a label for 2.x so that we can categorize issues?

aslakknutsen commented 10 years ago

@bartoszmajsak it exists :)

aslakknutsen commented 10 years ago

@bartoszmajsak 2.0 milestone

gastaldi commented 10 years ago

Now in the correct thread: i agree that JUnit should be the default choice. Who uses TestNG nowadays? ;)

aslakknutsen commented 10 years ago

As @bartoszmajsak pointed out, the list is actually a a lot longer then those two option. Those two are just the ones that are currently built in.

Maybe it would make sense to split them somehow.. (especially when we integrate all extensions in general)

Instead of 'setup arquillian', then user could give some pre hint to what h's trying to do, e.g.;

arquillian-test-bdd-functional-frontend <-- (named just to make the command complicated atm)

agoncal commented 10 years ago

Something like this ?

arquillian-create-test
arquillian-create-bdd-test
arquillian-create-selenium-test
aslakknutsen commented 10 years ago

in theory they could just be aliases, but.. yea..

Some way to describe and provide a 'solution', not just dump single components on a user