fork-handles / forkhandles

Foundational libraries for Kotlin
https://forkhandles.dev
Apache License 2.0
224 stars 28 forks source link

Fix variable name in comment of Result#recover function #81

Open christxph opened 2 weeks ago

christxph commented 2 weeks ago

The even better solution would probably be to rename the function argument from errorToValue to failureToValue because the whole Result4k type does not use the term error, however I was not sure if that may be a breaking change that we do not want to introduce so it's a start to at least fix the reference in the comment.

daviddenton commented 1 week ago

I think we should actually do the breaking change - it's quite unlikely to actually bust much as there is only a single parameter so the likelihood of people naming it is low :)