search

fork-maintainers / iceraven-browser

Iceraven Browser
4.7k stars 221 forks source link

[Bug] Shield (tracking protection) is stuck off in all tabs opened while the app is running, and only on for restored tabs #86

Open aquaspy opened 4 years ago

aquaspy commented 4 years ago

Steps to reproduce

Expected behavior

open zoom.com.br tracking protection should be enabled

Actual behavior

tracking protection is disabled and even turning it on, it turns ofd itself

Device information

zenfone 4 selfie snapdragon 430 (arm 64)

Screenshot_20200908-162735

aquaspy commented 4 years ago

I changed the blocker for "custom" instead of strict and the issue is solved.

CharmCityCrab commented 4 years ago

This bug should be reopened.

That the original poster was satisfied with the workaround of changing tracking protection from strict to custom to reenable tracking protection on a site where strict protection automatically got turned off does not make strict protection turning itself off not a bug.

I just had the same issue on Reddit, ironically while viewing a post about tracking, and right now I am having the same problem viewing this very page on GitHub and am in a pitched battle with my browser wherein I keep turning it tracking protections back on and it keeps turning them back off.

I can file a fresh issue about this bug if this is going to stay closed, but proper procedure was that this should have stayed open. It's not a self-help forum where it's only an issue until the original poster finds a good workaround that meets his or her personal needs, it's an issue until the actual bug is solved for everyone by restoring the expected behavior.

I will file a fresh issue about filing issues, because I have a suggestion that might limit this sort of premature closing of issues...

No offense to the original poster intended! It's good that he filed the issue. It just hasn't been solved yet. :)

CharmCityCrab commented 4 years ago

This issue doesn't seem to be immediately reproduceable in Firefox stable.

It may be that it has something to do with Firefox code ported over from nightly, Iceweasel specific code, code removed from Iceweasel, and/or an unexpected interaction between any of the above, potentially including Firefox stable code. Of course it's also possible that Firefox stable has the bug, too, and I just wasn't seeing it immediately clicking around.

Can anyone reproduce this on any official Firefox builds? Has anyone seen a similar issue on their Github?

interfect commented 4 years ago

I've reopened this as it seems to affect multiple users. Sounds like there's a workaround but no real fix yet.

interfect commented 4 years ago

I can reproduce this. Open a page (like http://example.com), and open the tracking protections dialog by clicking the shield (which has the enabled icon), and the switch in the dialog will be off. Turn it on, close the dialog, and open it again, and it is back to off.

We'll have to look at what if anything is coming up in the logs when this happens.

I wonder how much of the tracking protection system relies on filter lists being pushed out from Mozilla through all that telemetry stuff we ripped out? Or, it could be we just aren't shipping the list in the APK; I doubt it's checked in to source control, and I don't know how it would get downloaded.

interfect commented 4 years ago

Tracking protection seems to be stuck off for any new tabs you open (via button or link long press), but properly on for any tabs that are restored. If you open the app switcher, swipe away the app, and then open it again, tracking protection magically enables itself for all tabs that were open.

interfect commented 4 years ago

With UBlock Origin off, I don't see any difference in the EFF Panopticlick results between the two types of tabs, or between either and Mozilla Firefox. They're all "Partial Protection" on the first two categories, and fail on all the rest. I'm not sure how to check if Tracking Protection is actually... protecting.

I wasn't able to turn up anything in adb logcat, but maybe someone else can. I was checking when I flip the switch on, but maybe the real issue is happening when the tab is opened. Maybe it's trying to do some kind of tracking protection telemetry?

interfect commented 4 years ago

I think it's secretly still on. Here's it showing that, while the tracking protection switch is apparently off, it has managed to block some trackers.

Screenshot_20200910-000524_Iceweasel

aquaspy commented 4 years ago

Well, while I found a workaround, I still find it strange, but I closed because I think I understood the shield wrong. I thought that it was disabling itself because the strict would break the site, so in custom I disabled the option to block all third cookies to avoid the shield disabling itself. Seems like I was wrong and it is a real bug. Thanks for reopening the issue

bbigam commented 4 years ago

It's an upstream bug: https://github.com/mozilla-mobile/fenix/issues/14949