search

formancehq / stack

Open Source Infrastructure for the Financial Internet
https://www.formance.com
Other
362 stars 50 forks source link

feat: Remove Auth from Gateway #1687

Closed flemzord closed 2 months ago

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes in this pull request involve the removal of authentication-related features from the gateway's configuration and status management. The AuthEnabled field has been eliminated from the GatewayStatus struct, and associated authentication logic has been removed from various components, including Caddyfile templates and related functions. This results in a streamlined configuration process and a shift in how the gateway handles authentication, indicating a potential move away from using authentication mechanisms in this context.

Changes

File Path Change Summary
components/operator/api/formance.com/v1beta1/gateway_types.go Removed AuthEnabled field from GatewayStatus struct and its print column definition.
components/operator/internal/resources/gateways/Caddyfile.gotpl Removed entire authentication configuration block from Caddyfile template.
components/operator/internal/resources/gateways/caddyfile.go Modified CreateCaddyfile function to remove auth parameter, simplifying its logic.
components/operator/internal/resources/gateways/configuration.go Modified createConfigMap function to exclude auth parameter, updating calls accordingly.
components/operator/internal/resources/gateways/init.go Removed authentication handling logic from Reconcile function, including retrieval of Auth.
components/operator/internal/tests/gateway_controller_test.go Removed test context for Auth object, including related setup and validation tests.
ee/gateway/pkg/plugins/auth.go Deleted file containing JWT authentication provider implementation, including all related methods.

Possibly related PRs

Poem

In the meadow where bunnies play,
Authentication has hopped away.
With gateways light and free to roam,
Simplicity has found a home.
No more checks, just joy and cheer,
A world of ease is finally here! 🐇✨

[!TIP]

OpenAI O1 model for chat - We have deployed OpenAI's latest O1 model for chat. - OpenAI claims that this model has superior reasoning capabilities than their GPT-4o model. - Please share any feedback with us in the [discussions post](https://discord.com/channels/1134356397673414807/1283929536186155099).
Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 6ec442e7be93152b0e4819b5ec91f8334496b951 and 4b56fdbf2ded67265cf74237c55a2af47527d95e.
Files ignored due to path filters (5) * `components/operator/config/crd/bases/formance.com_gateways.yaml` is excluded by `!**/*.yaml` * `components/operator/helm/crds/templates/crds/apiextensions.k8s.io_v1_customresourcedefinition_gateways.formance.com.yaml` is excluded by `!**/*.yaml` * `components/operator/internal/tests/testdata/resources/gateway-controller/configmap-with-ledger-and-auth.yaml` is excluded by `!**/*.yaml` * `ee/gateway/go.mod` is excluded by `!**/*.mod` * `ee/gateway/go.sum` is excluded by `!**/*.sum`, `!**/*.sum`
Files selected for processing (8) * components/operator/api/formance.com/v1beta1/gateway_types.go (0 hunks) * components/operator/docs/09-Configuration reference/02-Custom Resource Definitions.md (0 hunks) * components/operator/internal/resources/gateways/Caddyfile.gotpl (0 hunks) * components/operator/internal/resources/gateways/caddyfile.go (1 hunks) * components/operator/internal/resources/gateways/configuration.go (1 hunks) * components/operator/internal/resources/gateways/init.go (1 hunks) * components/operator/internal/tests/gateway_controller_test.go (0 hunks) * ee/gateway/pkg/plugins/auth.go (0 hunks)
Files not reviewed due to no reviewable changes (5) * components/operator/api/formance.com/v1beta1/gateway_types.go * components/operator/docs/09-Configuration reference/02-Custom Resource Definitions.md * components/operator/internal/resources/gateways/Caddyfile.gotpl * components/operator/internal/tests/gateway_controller_test.go * ee/gateway/pkg/plugins/auth.go
Files skipped from review due to trivial changes (1) * components/operator/internal/resources/gateways/caddyfile.go
Files skipped from review as they are similar to previous changes (2) * components/operator/internal/resources/gateways/configuration.go * components/operator/internal/resources/gateways/init.go
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.