search

formidable-webview / webshell

🔥 Craft Robust React Native WebView-based components with ease.
https://formidable-webview.github.io/webshell/
MIT License
102 stars 4 forks source link

feat: support custom `data-` attributes in `HandleLinkPressFeature` #14

Closed bsnelder closed 3 years ago

bsnelder commented 3 years ago

Adds support for getting data- attributes of the anchor that was clicked.

jsamr commented 3 years ago

@bsnelder Thanks for your proposal! Did you perform manual tests? On iOS / Android? Thanks for letting me know.

codecov-commenter commented 3 years ago

Codecov Report

Merging #14 (882ff51) into master (c7d1e48) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #14   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files          13       13           
  Lines         175      175           
  Branches       29       29           
=======================================
  Hits          137      137           
  Misses         20       20           
  Partials       18       18
Impacted Files Coverage Δ
...es/webshell/src/features/HandleLinkPressFeature.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c7d1e48...882ff51. Read the comment docs.

bsnelder commented 3 years ago

@bsnelder Thanks for your proposal! Did you perform manual tests? On iOS / Android? Thanks for letting me know.

Yes tested on both iOS and Android. The dataset property has been supported for quite some years.

jsamr commented 3 years ago

Released today :fireworks: https://github.com/formidable-webview/webshell/releases/tag/v2.6.0

bsnelder commented 3 years ago

Thank you 👍