search

formtools / module-form_builder

The Form Builder module.
https://docs.formtools.org/modules/form_builder/
15 stars 21 forks source link

'Form is online' radio button does not save when publishing (Form Builder 2.0.9) #28

Closed nicktalsma closed 6 years ago

nicktalsma commented 6 years ago

Just tried upgrading from Form Builder 2.0.7 to 2.0.9. Also upgraded to the latest API and theme at the same time

Two of my dozen or so forms that were previously online where switched to offline under the publisher. When trying to switch back to online the settings would not save. Tried several times.

I re-uploaded the form_builder folder from the backup I made (effectively reverting back to 2.0.7) and was able to change the forms back to online, with the changes sticking.

benkeen commented 6 years ago

Hi @nicktalsma, I'm afraid I'm not able to reproduce this & it's really tricky to know what to suggest for debugging... hmm. 2.0.8 fixed a bug where forms were being incorrectly flagged as offline - it sounds like the problems you're experiencing are something to do with that fix.

I don't suppose there's any way I could get access to your system to debug this? No worries if not, I do understand.

nicktalsma commented 6 years ago

I actually set up a test environment for you to look at.

How would you like me to send you the location and creds?

On May 29, 2018, at 10:12 PM, Benjamin Keen notifications@github.com wrote:

Hi @nicktalsma, I'm afraid I'm not able to reproduce this & it's really tricky to know what to suggest for debugging... hmm. 2.0.8 fixed a bug where forms were being incorrectly flagged as offline - it sounds like the problems you're experiencing are something to do with that fix.

I don't suppose there's any way I could get access to your system to debug this? No worries if not, I do understand.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

benkeen commented 6 years ago

For anyone reading this, we got to the bottom of it. The offline_date field in the form_builder_forms table hadn't been updated properly to allow null values. This shouldn't have been the case: upgrading should have set that field properly so possibly there's a problem with the upgrade code. I'm going to investigate this today with #30.