forrestguice / SuntimesWidget

Android app (and widget collection) that displays sunlight and moonlight times.
GNU General Public License v3.0
350 stars 61 forks source link

[Feature request] Islamic prayer times add-on #729

Open islam2hamy opened 1 year ago

islam2hamy commented 1 year ago

Hello @forrestguice ,

May i ask you for a new add-on ( Islamic prayer times )

and this may help : https://github.com/batoulapps/adhan-js

Thank you

islam2hamy commented 1 year ago

@forrestguice can it be one of (sun data source ) ?

forrestguice commented 1 year ago

I'm very sorry but I don't foresee myself coding this add-on. I'm extremely hesitant to develop or maintain apps that I don't personally use. I think the maintenance part is particularly onerous (and not a responsibility to be taken lightly).

However, if someone else wants to develop and publish this, I'm willing to help them navigate that process, or even contribute code. I'm just not willing to take responsibility for the project myself.

To implement this, the add-on needs to query a content provider, perform some of its own calculations, and then display the results somehow. To supply alarms it will also need to implement its own "alarm provider" and advertise that in its manifest.

I think the quickest route would be to fork IntervalMidpoints as the starting point. Its already performing these steps, so its a matter of making modifications. It could also be coded from scratch (using favorite language/toolkit/library/whatever), the only important detail is that it uses the content-provider; https://developer.android.com/guide/topics/providers/content-provider-basics.

BTW, the "data source" extensions are mostly unrelated. These are useful if you want to replace the library that performs the sunrise/sunset calculations, etc, with some other library.

islam2hamy commented 1 year ago

Thank you for your reply ,

BTW : your app already can calculate 4 of 5 prayer times (morning astronomical, solar none , sunset , evening astronomical ) The missing one for me is depending on the object shadow,

could you please just add an ability to this app to create alarm depending on object shadow ?

forrestguice commented 12 months ago

could you please just add an ability to this app to create alarm depending on object shadow ?

Yes. I'm willing to do that. 👍 I think its actually requested already in #331, but I didn't understand its potential use cases.

islam2hamy commented 12 months ago

Thank You

islam2hamy commented 3 months ago

Hello @forrestguice ,

Thank you for the new custom events based on "shadow length" it is very good , but i have found that in my case i need to acumelat the shadow length of 2 events , one depend on the shadow length and the other depend on the shadow for the sun event

could it be done in the next release ?

forrestguice commented 3 months ago

hrm, possibly, but I'm trying to understand this better. Can you walk me through an example?

islam2hamy commented 3 months ago

hrm, possibly, but I'm trying to understand this better. Can you walk me through an example?

Define the time for "Asr" as when the shadow of an object is the same length as the object itself plus the shadow length at midday (solar none)

islam2hamy commented 3 months ago

IMG_٢٠٢٤٠٨١٥_٠٤٤٢٣٣

IMG_٢٠٢٤٠٨١٥_٠٤٤٣٥٢