search

forslund / fallback-aiml

An Alice chatbot fallback for Mycroft (all hail JarbasAI who did most of the work)
Apache License 2.0
12 stars 13 forks source link

Basic AIML cleaning #31

Open jrwarwick opened 4 years ago

jrwarwick commented 4 years ago

For now, just removing more stuff that is too-specific to original sources (pandorabots, mitsuku, etc) or is cannot be triggered. Just a wee little bit of Mycroft-ification, but only what is peripheral and obvious. Later PRs will address direct knowledge of Mycroft by Mycroft and consolidation and reorganization. This would further address #9

jrwarwick commented 4 years ago

After all that effort, a classic case of "right under my nose". The very aiml library utilized by the skill has in its repository a set of "standard" aiml files, which does appear to be of the same general lineage, but a bit more recent and cleaned up. 23,000 categories or so, vs 50,000 or so in the current list, and nothing about pandorabots: https://github.com/Calysto/aiml/tree/master/aiml/botdata/standard Since this is actually part of the pypi package, it is actually already on the filesystem of a running mycroft instance! /opt/venvs/mycroft-core/lib/python3.4/site-packages/aiml/botdata/standard/

I think this is the clear best way forward, so I am going to create a new PR that entirely replaces existing aiml set with the "standard" and then later on we can cherry pick the clever stuff (that will actually work in a mycroft context) from https://github.com/pandorabots/Free-AIML (which appears to be the origin of the current set).