search

forslund / mopidy_skill

A Mycroft skill for controlling the mopidy media player
GNU General Public License v3.0
15 stars 14 forks source link

Added Functionality To Play Single Track #23

Closed astrowave closed 5 years ago

astrowave commented 5 years ago

Currently works as expected in the local collection but could do with testing on Spotify and GMusic accounts as I am unable to test that. Should be fine.

forslund commented 5 years ago

The config member was dropped as part of 19.08 so the lines relating to that should be removed but I think settings should remain.

Den lör 23 nov. 2019 09:53astrowave notifications@github.com skrev:

@astrowave commented on this pull request.

In init.py https://github.com/forslund/mopidy_skill/pull/23#discussion_r349864646:

@@ -22,10 +22,10 @@ def init(self):

 def _connect(self, message):
     url = 'http://localhost:6680'
  • if self.settings:
  • url = self.settings.get('mopidy_url', url)
  • if self.config:
  • url = self.config.get('mopidy_url', url) +# if self.settings: +# url = self.settings.get('mopidy_url', url) +# if self.config: +# url = self.config.get('mopidy_url', url)

Ah, I had forgot to revisit that bug. Yes I meant to comment it out initially as for me at least it couldn't get config and so the skill didn't connect to mopidy.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/forslund/mopidy_skill/pull/23?email_source=notifications&email_token=AAGENP26TEQ2XU4T3GCSXMTQVDVPVA5CNFSM4JQUEHZKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCMX5F4Q#discussion_r349864646, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGENP24XPM7YWMEUXLSVYTQVDVPVANCNFSM4JQUEHZA .

forslund commented 5 years ago

I restored the settings and merged this. Many thanks!