Open KathyReid opened 6 years ago
The expected behaviour is to default to currently active device, otherwise play on the device that heard the invocation, if that is not found try the best matching device.
Can you ask for the available Spotify devices and make sure all your mark-1's are listed so it's not something like an error in librespot that has left you with only one device? what spotify devices are available?
Adding the possibility for a "default" device is not a bad idea, another example where this is useful is if the user has a Spotify device connected to the stereo that should play the music primarily.
You can also move playback between devices: move spotify playback to <DEVICE_NAME>
I'm getting no response with
What Spotify devices are available?
(ie nothing is returned, no audio cue, no visual cue)
What should be returned here - such as an enum
list or similar of Device names?
If connected spotify devices are found it should answer with something like: "I see the Spot-ify devices named: DEVICE and DEVICE" or "I've found the Spot-ify devices named: DEVICE and DEVICE"
If no spotify devices are found it will answer with
"I couldn't find any Spot-ify devices. This skill requires a Spot-ify Premium account to work properly." or "There are no Spot-ify devices available. Make sure you have a Spot-ify Premium account."
Adding the possibility for a "default" device is not a bad idea, another example where this is useful is if the user has a Spotify device connected to the stereo that should play the music primarily.
This one would help me a lot.
You can also move playback between devices: move spotify playback to
move/transfer does not work in my setup (yet) i dont know if this is implemented already in debugging mode nothing happends on the phrase as mentioned (even typing it to make sure its not the tts part
I've started work on this in #37.
The transfer spotify to SOMEWHERE
works here, it requires that the skill has started playback and that the skill can find the device (check by asking what spotify devices are available
)
Description of Issue in object-deviation format
If a user has more than one Mycroft device with the
mycroft-spotify
Skill installed, Mycroft does not know which device to stream to. From observation, it appears Mycroft will stream music to the first device on which the Skill was installed.I'm not sure what the "expected" behaviour should be here - it's an edge case, because it's unlikely that many users will have > 1 Mycroft device installed AND have
mycroft-spotify
installed on all devices.Thoughts on resolution
This is likely due to the way that the Spotify API handles devices.
Suggested resolution:
Use
skill-settings
to have the user define an order of precedence if they have multiple Mycroft devices installed. Themycroft-spotify
Skill would then use the order of precedence to stream to the first available Mycroft device.Use voice conversational context to get the user to specify which Mycroft device the audio should be streamed to prior to buffering and playback.