fortify / github-action

Fortify GitHub Actions
Other
10 stars 9 forks source link

How to use latest version of tools? #48

Closed crance closed 2 months ago

crance commented 2 months ago

Question

In sc-sast-scan and fod-sast-scan, tools eg: sc-client used in package action is using version 23.2.1 instead of latest version.

https://github.com/fortify/github-action/blob/6375519eb64590a413c417f4860be2f0d558197f/package/action.yml#L7-L10

https://github.com/fortify/github-action/blob/6375519eb64590a413c417f4860be2f0d558197f/setup/src/constants.ts#L20-L22

Can we override the sc-client version when using sc-sast-scan and fod-sast-scan action, without hosting a separate tool definition zip? I would also want to know how to override versions of other tools especially fcli

Thanks

rsenden commented 2 months ago

Hi,

The fortify/github-action/setup action automatically supports all tool versions listed in our default tool definitions, which gets automatically updated on a daily basis (with some manual work needed for ScanCentral Client; latest supported version is 24.2.0 which I believe is the latest version). There's no need to use custom tool definitions unless you want the setup action to download the various tools from some internal artifact repository (useful for GitHub Enterprise installations where actions are not allowed to download software from public internet sites).

The workflow-style actions like fortify/github-action/fod-sast-scan or fortify/github-action/sc-sast-scan use fixed tool versions (as defined in constants.ts) to avoid these actions from breaking if new tool versions introduce any breaking changes. You currently can't override these (might be good to support overrides though); we need to release a new version of those actions to upgrade the underlying tool versions.

I'm working on updating our GitHub Actions to introduce some new features, and also update underlying tool versions; I hope to have this available in the next 1-2 months but can't give any guarantee.

crance commented 2 months ago

Thanks @rsenden for the clarification. Looking forward for the updates.