data/labels.json should use named keys for dataset slots

fortytw0 / needfinder

Cheap and Fast - But is it better?

MIT License

1 stars 0 forks source link

data/labels.json should use named keys for dataset slots #10

Closed AbeHandler closed 2 years ago

AbeHandler commented 2 years ago

from src.main

Using numbered slots for each dataset will get really confusing. We should refactor.

fortytw0 commented 2 years ago

I agree - ideally this should change, but at the moment since we are only focussing on these subreddits, I am lettting it slide. In the future, I envision a command line prompt that will accept a JSON file path. Don't know if this is satisfactory- but please let me know if it won't work for your purposes

AbeHandler commented 2 years ago

works for me for now!

fortytw0 commented 2 years ago

Can this issue be closed?