fossasia / badgemagic-android

Badge Magic with LEDs - Android App https://play.google.com/apps/testing/org.fossasia.badgemagic
Apache License 2.0
1.85k stars 206 forks source link

fix: widget overflow resolved #1069

Closed Dhruv80576 closed 3 weeks ago

Dhruv80576 commented 3 weeks ago

Fix #1066 Please find attached screenshots to verify image image

Summary by Sourcery

Bug Fixes:

sourcery-ai[bot] commented 3 weeks ago

Reviewer's Guide by Sourcery

This PR fixes a widget overflow issue (#1066) by implementing responsive layout changes. The main changes involve wrapping containers in Expanded widgets and adjusting layout properties to ensure proper widget sizing and alignment.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Improved badge container layout responsiveness
  • Wrapped Container widget in Expanded with flex: 1
  • Adjusted horizontal margin from 20.w to 10.w
  • Added mainAxisAlignment.center to Row widget
lib/view/draw_badge_screen.dart
Modified save dialog layout to prevent overflow
  • Wrapped Text widget in Expanded with flex: 1
  • Removed SizedBox spacing (commented out)
  • Adjusted text widget structure for better layout
lib/view/widgets/save_badge_dialog.dart

Assessment against linked issues

Issue Objective Addressed Explanation
#1066 Fix widget overflow issues during popups
#1066 Fix widget overflow issues during screen orientation changes

Possibly linked issues


Tips and commands #### Interacting with Sourcery - **Trigger a new review:** Comment `@sourcery-ai review` on the pull request. - **Continue discussions:** Reply directly to Sourcery's review comments. - **Generate a GitHub issue from a review comment:** Ask Sourcery to create an issue from a review comment by replying to it. - **Generate a pull request title:** Write `@sourcery-ai` anywhere in the pull request title to generate a title at any time. - **Generate a pull request summary:** Write `@sourcery-ai summary` anywhere in the pull request body to generate a PR summary at any time. You can also use this command to specify where the summary should be inserted. #### Customizing Your Experience Access your [dashboard](https://app.sourcery.ai) to: - Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others. - Change the review language. - Add, remove or edit custom review instructions. - Adjust other review settings. #### Getting Help - [Contact our support team](mailto:support@sourcery.ai) for questions or feedback. - Visit our [documentation](https://docs.sourcery.ai) for detailed guides and information. - Keep in touch with the Sourcery team by following us on [X/Twitter](https://x.com/SourceryAI), [LinkedIn](https://www.linkedin.com/company/sourcery-ai/) or [GitHub](https://github.com/sourcery-ai).
adityastic commented 3 weeks ago

Fix failing checks. Else looks good!

Dhruv80576 commented 3 weeks ago

failing checks fixed