Closed sarnava1 closed 5 years ago
@sarnava1 Screenshots or gif??
@pranav1698 sorry!! My mistake. Actually I took the screenshot but still forgot to post it.
@tabesin @meets2tarun @mariobehling please review my PR.
@pranav1698 the color of the menu button changes to black only when hovered over it. Otherwise it is still the old white as it was. I changed the color to black when hovered over it because the present hover effect was introduced by a GCI student and I felt it was best not to remove that hover effect. If we had removed the hover effect the issue would have been solved @tabesin @meets2tarun @mariobehling
@sarnava1 I was asking to change the css on hover only; I am not asking to remove the hover effect
On Mon, Oct 29, 2018, 14:40 Sarnava Konar notifications@github.com wrote:
@pranav1698 https://github.com/pranav1698 the color of the menu button changes to black only when hovered over it. Otherwise it is still the old white as it was. I changed the color to black when hovered over it because the present hover effect was introduced by a GCI student and I felt it was best not to remove that hover effect. If we had removed the hover effect the issue would have been solved @tabesin https://github.com/tabesin @meets2tarun https://github.com/meets2tarun @mariobehling https://github.com/mariobehling
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/meilix-generator/pull/320#issuecomment-433836776, or mute the thread https://github.com/notifications/unsubscribe-auth/AhJO2W5vjza9CMnrioYQFau38JdtWFZAks5upsYAgaJpZM4X9lkX .
Checklist
master
branch.Short description of what this resolves:
Menu icon now visible when hovered over it. Initially the menu icon was not visible when we hovered over it ie during the mouse enter operation.
Fixes #319