This removes the unnecessary variable INSTALL which has the same value as the recipe variable - (Solves- #437)

pranav1698 commented 5 years ago

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] There is a corresponding issue for this pull request.
[x] My branch is up-to-date with the Upstream master branch.
[ ] The unit tests pass locally with my changes (provide a screenshot or link for test)
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Short description of what this resolves:

This solves the unexpected error Sorry, unexpected error: str expected, not list, The INSTALL array was not required, the value of the array is same as the recipe array but with different names, I have made the changes equivalent to what we were doing previously Check one of the meilix builds triggered by the webapp and notice that the recipe array is already sending the 3rd party softwares into the build server

Changes proposed in this pull request:

Removing the INSTALL variable

Fixes #437

pranav1698 commented 5 years ago

@tabesin @xeon-zolt do we need chrome even after we are already adding chromium

pranav1698 commented 5 years ago

@tabesin we can have the name of the inputs for the softwares same or different, value of the inputs will remain same I thought that it will bring clarity if we specify the name of inputs with the value of inputs as we were doing before #435 is merged, we can still make the name of the inputs same

xeon-zolt commented 5 years ago

chromium and chrome are the same things

rpotter12 commented 5 years ago

Through meilix-generator we are providing an option for users to choose his/her own browser, so providing an option for chrome also should not be a problem.

rpotter12 commented 5 years ago

@tabesin this pull request should not be merged because the changes are already made in meilix repository with respect to old changes #435 . This pull request will break the installation of 3rd party software which are selected by checkbox.

rpotter12 commented 5 years ago

@tabesin @xeon-zolt @meets2tarun please review it again

meets2tarun commented 5 years ago

ok, lets have a look,

thanks for the notification @rpotter12

fossasia / meilix-generator