fossasia / open-event-attendee-android

Open Event Attendee Android General App https://github.com/fossasia/open-event-android/blob/apk/open-event-dev-app-playStore-debug.apk
Apache License 2.0
1.96k stars 551 forks source link

Do not open tickets if the order status is not completed #2077

Closed liveHarshit closed 1 year ago

liveHarshit commented 5 years ago

Describe the bug Currently, tickets are fetching if the order status is incompleted.

Would you like to work on the issue?

Open for all

captain82 commented 5 years ago

@liveHarshit I would like to work on this issue.

liveHarshit commented 5 years ago

@liveHarshit I would like to work on this issue.

Please go ahead. Also, we assign one issue at a time. For reference #1932

captain82 commented 5 years ago

@liveHarshit I will work on this issue first.

captain82 commented 5 years ago

@liveHarshit Can you describe a little what exactly needs to happen?

liveHarshit commented 5 years ago

@liveHarshit Can you describe a little what exactly needs to happen?

In the tickets section, order status is displaying for tickets. Sometimes an order is pending(due to incomplete payment), then instead of opening ticket details, it should redirect for payment. And for another status (canceled or expire), only a message should display. Open the ticket only when order is completed or placed(in case of offline payment)

captain82 commented 5 years ago

@liveHarshit ok Thank you

captain82 commented 5 years ago

@liveHarshit How do I make an incomplete payment order?

liveHarshit commented 5 years ago

@liveHarshit How do I make an incomplete payment order?

With order identifier. Check how order is creating in attendee fragment. API docs: https://open-event-api-dev.herokuapp.com

Open Event API Server
captain82 commented 5 years ago

@liveHarshit when the status is pending the user should be redirected to Attendee Fragment where the countdown of 15 minutes begins to complete the payment,right?

liveHarshit commented 5 years ago

@liveHarshit when the status is pending the user should be redirected to Attendee Fragment where the countdown of 15 minutes begins to complete the payment,right?

I'm not sure if we can update attendees. Please check the frontend implementation. Debug: https://open-event-fe.netlify.com Release: eventyay.com

captain82 commented 5 years ago

Thanks @liveHarshit

captain82 commented 5 years ago

@liveHarshit When i try pay using paymal sandbox ,it says your selected payment method was not accepted.Need help.

liveHarshit commented 5 years ago

@liveHarshit When i try pay using paymal sandbox ,it says your selected payment method was not accepted.Need help.

Use client Id: AXrRge-gN1E5WHMYsu0FsftPOWBjTu3Sqj0pKfpq7mPKwv6w_ikiqWrka_06lAWZW5_WxL9CwaMiTVsc with the debug server.

captain82 commented 5 years ago

@liveHarshit Pending Tickets are now being paid successfully using paypal .How do i test for Stripe payment.I am unable to create a event with stripe as payment method.

liveHarshit commented 5 years ago

@liveHarshit Pending Tickets are now being paid successfully using paypal .How do i test for Stripe payment.I am unable to create a event with stripe as payment method.

If it is working with PayPal then do the same for stripe.

captain82 commented 5 years ago

@liveHarshit I think pending orders can be created only with PayPal and not Stripe as no parameter is obtained for card details. If a user chooses Stripe payment it can either be a success or failure during first-time ticket booking. Correct me if I am wrong?

liveHarshit commented 5 years ago

@liveHarshit I think pending orders can be created only with PayPal and not Stripe as no parameter is obtained for card details. If a user chooses Stripe payment it can either be a success or failure during first-time ticket booking. Correct me if I am wrong?

User needs to enter details again.

captain82 commented 5 years ago

@liveHarshit So do i have to make a new screen for that?

liveHarshit commented 5 years ago

user should be redirected to Attendee Fragment

captain82 commented 5 years ago

@liveHarshit Are you sure? Because the same could have been done for Paypal

liveHarshit commented 5 years ago

@liveHarshit Are you sure? Because the same could have been done for Paypal

What if the user wants to pay with stripe. Open attendee section with same order identifier. So that order will complete after payment is done. Got it?

liveHarshit commented 5 years ago

@iamareebjamal Your opinion?

captain82 commented 5 years ago

@liveHarshit Are you sure? Because the same could have been done for Paypal

What if the user wants to pay with stripe. Open attendee section with same order identifier. So that order will complete after payment is done. Got it?

I think this is possible .Lets see what @iamareebjamal says

captain82 commented 5 years ago

@liveHarshit Should i proceed with your mentioned method or wait for @iamareebjamal

iamareebjamal commented 5 years ago

Yes

captain82 commented 5 years ago

@liveHarshit I want to make a PR for this bug

liveHarshit commented 5 years ago

@liveHarshit I want to make a PR for this bug

Yes please.

captain82 commented 5 years ago

@liveHarshit ok

captain82 commented 5 years ago

@liveHarshit Just made a PR.

kshitij-99 commented 5 years ago

Please close this issue.

liveHarshit commented 5 years ago

Please close this issue.

Why?

thatfedupguy commented 5 years ago

Is this issue still open ??...would like to work on it.

rob729 commented 5 years ago

@liveHarshit Can I work on this issue?

liveHarshit commented 5 years ago

There is already a PR. @captain82 What is the status?

iamareebjamal commented 5 years ago

2 months, so most likely won't continue

liveHarshit commented 5 years ago

@rob729 Go ahead. First read all comments on the previous PR and understand the issue.

thatfedupguy commented 5 years ago

@liveHarshit I have asked first if I can work on this issue or not. Please assign it to me.

liveHarshit commented 5 years ago

@liveHarshit I have asked first if I can work on this issue or not. Please assign it to me.

GO AHEAD

rob729 commented 5 years ago

@tusharr-98 Are you still working on this issue?

thatfedupguy commented 5 years ago

@rob729 yes...I have asked some questions related to the last PR from @liveHarshit but haven't got any reply.

iamareebjamal commented 5 years ago

Where's the question?

thatfedupguy commented 4 years ago

https://github.com/fossasia/open-event-attendee-android/pull/2356#discussion_r349884297

thatfedupguy commented 4 years ago

@liveHarshit, how should I get the order and event by their ids as they are required as a parameter to start PayPal payment?

liveHarshit commented 4 years ago

@liveHarshit, how should I get the order and event by their ids as they are required as a parameter to start PayPal payment?

From order fragment and order under user view model.

thatfedupguy commented 4 years ago

I am unable to create a pending order, need help

thatfedupguy commented 4 years ago

Also every time I am trying to create order...snackbar appears with a message "unable to create order".

rob729 commented 4 years ago

@tusharr-98 Are you still working on this issue?

thatfedupguy commented 4 years ago

@rob729 are you able to create Order ??

thatfedupguy commented 4 years ago

@liveHarshit help needed

liveHarshit commented 4 years ago

@liveHarshit help needed

yes?