search

fossology / fossology-python

Python wrapper for the Fossology API
https://fossology.github.io/fossology-python
MIT License
17 stars 8 forks source link

Fix/content disposition #97

Closed deveaud-m closed 2 years ago

deveaud-m commented 2 years ago

This patch improves robustness against different type of quotes (or no quotes at all) in the Content-Disposition header while reading the name of the downloaded report.

Fixes #96

codecov[bot] commented 2 years ago

Codecov Report

Merging #97 (976eabe) into master (56f639c) will decrease coverage by 0.42%. The diff coverage is 78.12%.

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   89.94%   89.52%   -0.43%     
==========================================
  Files          11       11              
  Lines        1333     1346      +13     
==========================================
+ Hits         1199     1205       +6     
- Misses        134      141       +7
Impacted Files Coverage Δ
fossology/__init__.py 93.29% <ø> (ø)
fossology/foss_cli.py 82.25% <0.00%> (ø)
fossology/obj.py 93.30% <ø> (ø)
fossology/uploads.py 85.46% <75.00%> (-1.05%) :arrow_down:
fossology/report.py 100.00% <100.00%> (ø)
fossology/__main__.py 0.00% <0.00%> (-75.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56f639c...976eabe. Read the comment docs.

deveaud-m commented 2 years ago

Due to breaking changes in Fossology API version 1.4.0, new commits were needed to support the new PATCH und PUT methods for /upload endpoint.

Additionally, fix #95 by adding a wait_time option to download_report.