Closed willmj closed 3 months ago
It seems like the second test you mentioned to add is covered already in test_get_hf_peft_config_returns_lora_config_correctly(). Let me know if there's any additional functionality there that needs testing.
assert (
config.target_modules is None
) # default value from local peft_config.LoraConfig
It seems like the second test you mentioned to add is covered already in test_get_hf_peft_config_returns_lora_config_correctly(). Let me know if there's any additional functionality there that needs testing.
assert ( config.target_modules is None ) # default value from local peft_config.LoraConfig
Yup, this is fine. Thank you!
Description of the change
Add unit test for recent change (PR #269) to verify that HF library correctly changes target_modules to the default values.
Related issue number
How to verify the PR
Run unit tests.
Was the PR tested