foundation-model-stack / fms-hf-tuning

🚀 Collection of tuning recipes with HuggingFace SFTTrainer and PyTorch FSDP.
Apache License 2.0
28 stars 48 forks source link

Add unit test to verify target_modules defaults correctly #281

Closed willmj closed 3 months ago

willmj commented 4 months ago

Description of the change

Add unit test for recent change (PR #269) to verify that HF library correctly changes target_modules to the default values.

Related issue number

How to verify the PR

Run unit tests.

Was the PR tested

willmj commented 4 months ago

It seems like the second test you mentioned to add is covered already in test_get_hf_peft_config_returns_lora_config_correctly(). Let me know if there's any additional functionality there that needs testing.

    assert (
        config.target_modules is None
    )  # default value from local peft_config.LoraConfig
aluu317 commented 3 months ago

It seems like the second test you mentioned to add is covered already in test_get_hf_peft_config_returns_lora_config_correctly(). Let me know if there's any additional functionality there that needs testing.

    assert (
        config.target_modules is None
    )  # default value from local peft_config.LoraConfig

Yup, this is fine. Thank you!