deps: Add protobuf to support aLLaM models

foundation-model-stack / fms-hf-tuning

🚀 Collection of tuning recipes with HuggingFace SFTTrainer and PyTorch FSDP.

Apache License 2.0

28 stars 48 forks source link

deps: Add protobuf to support aLLaM models #336

Closed willmj closed 2 months ago

willmj commented 2 months ago

Description of the change

Add protobuf to enable compatibility with certain models, as done in patch release v1.2.2

Related issue number

How to verify the PR

Was the PR tested

[ ] I have added >=1 unit test(s) for every new method I have added.
[x] I have ensured all unit tests pass

anhuong commented 2 months ago

Related PR into release branch - https://github.com/foundation-model-stack/fms-hf-tuning/pull/328

anhuong commented 2 months ago

I initially was thinking we could pull in the same commit onto release branch to try to minimize the merge conflict at release time by doing something like git cherry-pick 1107e0042e7e4fdfa8e60f8fb33a03327b2278f6 but since this PR will squash merge into main branch, I don't think we can avoid having the same change but different commits on main and release branch. I don't think it should be too much of an issue at release time since they are the same change, but we shall see.