search

foundation-model-stack / fms-hf-tuning

🚀 Collection of tuning recipes with HuggingFace SFTTrainer and PyTorch FSDP.
Apache License 2.0
28 stars 48 forks source link

docs: Data Preprocessor ADR #374

Closed dushyantbehl closed 1 week ago

dushyantbehl commented 1 month ago

Description of the change

This PR adds an ADR for the newly proposed changes to the data pre procesor implementation in fms-hf-tuning.

github-actions[bot] commented 1 month ago

Thanks for making a pull request! 😃 One of the maintainers will review and advise on the next steps.

dushyantbehl commented 1 week ago

This is very clear and gives great explanation of the use-cases, details, and design considerations. Have a couple of nitpicks and one question about required arguments below but it looks good to me!

Thanks @willmj fixed the nits.