search

foundation / foundation-sites

The most advanced responsive front-end framework in the world. Quickly create prototypes and production code for sites that work on any kind of device.
https://get.foundation
MIT License
29.67k stars 5.48k forks source link

aria-expanded not accepatble with role="menuitem" #10158

Closed getvijayji closed 7 years ago

getvijayji commented 7 years ago

I am using foundation6 data-accordion-menu, and the accordion is working fine too. but it seems that foundation6 is injecting the ARIA attributes dynamically, where it is putting aria-expanded and role="menuitem" together in

  • elements which isn’t allowed by the ARIA spec. Is there any fix for this. And also when i am putting the role="none" in my code, this is overridden when code gets rendered.

    Please help.

    here is the code generated

    • brettsmason commented 7 years ago

    @getvijayji thanks for reporting this. Can you let me know how this should be setup in order to pass?

    brettsmason commented 7 years ago

    @getvijayji Having looked at this again I can see its actually been fixed in the upcoming 6.4 release, see here: https://github.com/zurb/foundation-sites/pull/10064. I'm going to close this.

    getvijayji commented 7 years ago

    Thanks I got that info in other tag and the foundation site.