search

foundry-rs / foundry

Foundry is a blazing fast, portable and modular toolkit for Ethereum application development written in Rust.
https://getfoundry.sh
Apache License 2.0
8.34k stars 1.77k forks source link

fix(forge create): set skip_is_verified_check: true #9222

Closed grandizzy closed 1 month ago

grandizzy commented 1 month ago

Motivation

Closes #9219

Solution

I am not sure if any good reason to create forge_verify::VerifyArgs with skip_is_verified_check: false for forge create https://github.com/foundry-rs/foundry/blob/a428ba6ad8856611339a6319290aade3347d25d9/crates/forge/bin/cmd/create.rs#L353 when in get_verify_args fn they are set to true https://github.com/foundry-rs/foundry/blob/a428ba6ad8856611339a6319290aade3347d25d9/crates/script/src/verify.rs#L149 changing this for consistency and to solve the issue where forge create always prints "is already verified. Skipping verification." without performing verification. @klkvr @yash-atreya can you please chime in?