Compatibility v10 - Githubissues

foundryvtt / world-anvil

A module to integrate World Anvil with Foundry Virtual Tabletop.

MIT License

12 stars 7 forks source link

Compatibility v10 #56

Closed adrien-schiehle closed 2 years ago

adrien-schiehle commented 2 years ago

The first three commits seems to come from somethink we already merged : Refresh button + category sort I don't know why it is back in this PR :(

The rest is V10 compliance + entry pages for new Journal management

13-08-2022: I recently added some additionnal changes du to another change in WA API. And while doing it, I added a new buttion for shrinking categories in the journal. (When you have a big WA world, it become difficult to navigate without it)

adrien-schiehle commented 2 years ago

Conflict seems to come from the fact I didn't retrieve all the changes that has been done during reviews.

I will try to see today how to do it with githubDesktop

adrien-schiehle commented 2 years ago

We may need to discuss what we want in term of pages for this v10

For now, I have :

One main page called Article / Character with the main WA Article content
Some additional pages named Portrait / Cover/ Image. (It's what was previously in journal.img)
Two pages named Side content and Secrets for other sections. (Only section with id seeded is for now inside Secrets page)
One last one for Relations. (this one is not totally ok for now)

There will also be a question on which one should be displayed first : Article or Image

adrien-schiehle commented 2 years ago

I like what you've done here to allocate the sections of the source WA article to different pages. I am not really sold on the idea of having a bunch of settings, do you think that users will really care to configure this? Could we simplify things and make this the default behavior?

I don't really remember why I choose to put them as parameters.

Perhaps, to allow people who only import characters to hand the page named Character instead of Article ?
- Or Perhaps to allow peaple using another language to use the module "as it is" without having to get a whole module translation file. (The GM seeing english text inside WAJournalBrowser is ok. But players seeing text in english when opening a Journal can tend to be a little anticlimatic)

I'm french myself. Until now, I didn't see the need to add a fr.json file to the project, since it was mainly for GM. I'm lucky : Article, Portrait, and Secrets are spelled the same in french, so I won't have the need. But it will be different for german people

aaclayton commented 2 years ago

Thanks! I'll merge this in and cut a V10 compatible release :)