search

foundryvtt / world-anvil

A module to integrate World Anvil with Foundry Virtual Tabletop.
MIT License
12 stars 7 forks source link

Sorting category upgrade + fix for issue #68 #72

Closed adrien-schiehle closed 1 year ago

adrien-schiehle commented 1 year ago

Sorting category upgrade

We did have an issue with WA API last on 11/06/2023 After talking with Gorkam, he fixed it so that it could work as before.

But during the talk, he explained me that he also added more information inside fall article retrieval. We now have the order of the articles contained in each category without having to make additional calls to the API ! So I integrated those data into our import process.

Fix for issue #68

I don't know why, but it seems that people can have articles without titles => I've added a check when sorting the article list.

adrien-schiehle commented 1 year ago

I've also added a little something so that only first level of category are opened.

It became difficult to look for what I needed when all category were displayed.

Here is what it has become on first load :

image
adrien-schiehle commented 1 year ago

Tests were done on my custom world and the one created for handling all special cases, like covers or relationships.

I did found another problem during my test phase, but not linked to this PR. article.cover.url and article.portrait.url does not have the same value as before.

Before : https://www.worldanvil.com/uploads/images/0076dd51bd11903370cbd5672deffa1b.png (just the image)

image

Now : https://www.worldanvil.com/i/2664497

image

Since it's not an image, it fails to import it correctly.

I will track this in an other ticket. But this PR has no impacts on this.