search

foxglove / ros-foxglove-bridge

Foxglove WebSocket bridge for ROS 1 and ROS 2
MIT License
168 stars 75 forks source link

Potential for documentation copy-paste error #295

Closed ZeKaiCheong closed 7 months ago

ZeKaiCheong commented 7 months ago

Changelog

Documentation typo error.

Description

The example given for including the foxglove bridge launch file in another XML launch file in ROS2 had an extra forward slash that was removed.

Prevent copy-paste issue.

BeforeAfter
```shell [INFO] [launch]: Default logging verbosity is set to INFO [ERROR] [launch]: Caught exception in launch (see debug for traceback): Caught multiple exceptions when trying to load file of format [xml]: - InvalidFrontendLaunchFileError: Caught multiple exceptions when trying to load file of format [xml]: - ParseError: mismatched tag: line 6, column 4 - RuntimeError: Expected only one root - SyntaxError: invalid syntax (foxglove_bridge_launch.xml, line 1) ```
defunctzombie commented 7 months ago

Something is stuck with the CLA check so I made a separate PR with the fix: https://github.com/foxglove/ros-foxglove-bridge/pull/296