search

foxnne / pixi

Pixel art editor made with Zig.
https://foxnne.github.io/pixi/
MIT License
645 stars 20 forks source link

Add tool options for size and shape #43

Closed no1hitjam closed 5 months ago

no1hitjam commented 5 months ago

Hotkeys included

resolves #35

foxnne commented 5 months ago

Thank you so much! I will take a look at this as soon as I have time. One note I'm a bit unsure of, I've been working on the sysgpu branch (and I also apologize this wasn't obvious), but allowing this project to use sysgpu required moving to a different binding so the other branch is a pretty hefty change to most of the project. I haven't really ever had much outside contribution so I'm a bit unfamiliar with the best way to handle merging these PR's.

no1hitjam commented 5 months ago

Got it, no problem. I'm not too experienced with git merges, but if it's a drastic difference I could imagine just reworking the change off of the new branch, which hopefully isn't too painful. It's something I could possibly look into once that stuff gets figured out.

foxnne commented 5 months ago

No worries! Worst case I can just work off your PR like you said. Thanks again!

foxnne commented 5 months ago

@no1hitjam Thanks again so much for your PR. I worked off of it and I'm about to merge those changes. I did things a little differently but overall all the same functionality is there. Bracket keys increase/decrease the stroke size. You can right click the pencil tool for a context menu with the options for it there, and a help text has been added to the hover popup over pencil/eraser.