search

fplll / fpylll

A Python interface for https://github.com/fplll/fplll
GNU General Public License v2.0
118 stars 60 forks source link

Support python 3.12 #254

Closed tornaria closed 10 months ago

tornaria commented 11 months ago

The necessary functions are copied from cpython 3.12 Include/internal/pycore_long.h, which is private. This should make it easy to copy new versions if cpython internals change. For cpython < 3.12 I implemented equivalent functions.

All of this is placed in separate files pycore_long.pxd and pycore_long.h copied from https://github.com/sagemath/cypari2/issues/137.

Tested in 64-bit and 32-bit x86.

Fixes: #246

tornaria commented 11 months ago

See https://github.com/sagemath/sage/pull/36407#issuecomment-1750585808 for an explanation of the change.

malb commented 11 months ago

Thank you so much for this, could you rebase your PR on the current master branch, it should resolve those CI failures.

tornaria commented 10 months ago

Thank you so much for this, could you rebase your PR on the current master branch, it should resolve those CI failures.

Done