search

framed-data / overseer

Overseer is a library for building and running data pipelines in Clojure.
Eclipse Public License 1.0
97 stars 10 forks source link

0.2.3: Add default sleep-time #12

Closed andrewberls closed 9 years ago

andrewberls commented 9 years ago

If a sleep-time is not specified in the config passed to the system, the system will silently fail with a NPE in Thread/sleep. This adds a default sleep time of 10s, which can be overridden by specifying (:sleep-time config)

elliot42 commented 9 years ago

http://stackoverflow.com/questions/16270805/how-to-get-the-version-of-the-current-clojure-project-in-the-repl

elliot42 commented 9 years ago

I'm :+1: on the sleep time, and we should get that in to unbreak the workers. I'm not a huge fan of the version thing, and I think we can do better, but it doesn't have to hold this up (on the other hand, that change also didn't need to go into this PR), so :+1: but I would like to change the version thing.

andrewberls commented 9 years ago

The version thing is a bit hacky, although IMO it beats remembering to change versions all over the place, which has tripped me up a few times. As mentioned, Rails uses the same technique, happy to talk more about it